On Wed, 31 Jan 2024 11:50:35 GMT, psoujany <d...@openjdk.org> wrote: >> @psoujany I still get two failing tests, possibly because I updated my local >> repository by merging the current master branch before running tests. This >> PR is based on a very outdated branch, so we should definitely merge the >> master branch before integrating. The failing tests I get on my up-to-date >> branch are these: >> >> jdk/javadoc/doclet/testPreview/TestPreview.java >> jdk/javadoc/doclet/testSpecTag/TestSpecTag.java > > @hns I've updated my branch and modified the failing tests. Now all tests > seems passing with the changes. Thank you.
@psoujany the last thing that needs to be updated is to change `script.js` to update the `aria-labelledby` attribute in the correct element as I did [in this pull request](https://github.com/psoujany/jdk/pull/1/files). Feel free to make the change yourself if there are problems with the pull request (github complains that I haven't signed the Eclipse Contributors Agreement, but that shouldn't be an issue for this OpenJDK change). ------------- PR Comment: https://git.openjdk.org/jdk/pull/16148#issuecomment-1919566840
