On Mon, 19 Feb 2024 13:32:06 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Please review a simple change to avoid placing non-list content in the > breadcrumb navigation bar. The solution I chose is to use the ` > ` separator > as list marker for all list items except the first one using the > `list-style-type` CSS property. An alternative solution would have been to > add the separator character to the list item content, but I think its role is > that of a list marker rather than list content. > > The visual presentation is very close to the previous solution with tiny bit > more spacing between list items. Nice! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java line 536: > 534: > 535: // Add the breadcrumb navigation links if present. > 536: var breadcrumbNav = HtmlTree.OL(HtmlStyle.subNavList); Why is it `OL` not `UL` ? ------------- Marked as reviewed by jjg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17917#pullrequestreview-1891254372 PR Review Comment: https://git.openjdk.org/jdk/pull/17917#discussion_r1496334456
