On Tue, 11 Jun 2024 13:03:47 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >> commits since the last revision: >> >> - Null safety >> - Merge branch 'master' into html-attributes >> - remove trailing whitespace >> - -Add a boolean attribute to the enum type >> -Simply regex in `visitAttribute` >> -Simplified the Test >> -Added a negative test >> - no longer print summary >> - no longer print summary >> - Add small comment >> - Remove classpath exception >> - Allow global variables > > test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C2.java line 104: > >> 102: * </p> >> 103: * >> 104: * <ul> > > Since you use `ol`, `ul`, and `li`elements, you could add global attributes > to them too. Otherwise, you only have such attributes in `p` elements. The more you go down this path, the more this seems like a combo test for generated code ;-) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1636662684
