On Wed, 31 Jul 2024 11:02:06 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Update another translation > Is it an incremental update since #19609? > > I cannot verify correctness of translation, but I can review this PR > generally for `jdk.javadoc`. > > From what I can see, the changes are only to the property files, which is > expected from the PR title. The keys from English files 1-1 match the keys > from non-English files: there are no missing or extra keys. > > From that point of view, the changes to `jdk.javadoc` look good. Thanks for your review! Yes, we have localization drops twice (RDP1 & RDP2). RDP1 will have a majority of the translations typically and the RDP2 drop is usually a minor update in comparison. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20394#issuecomment-2261356696