On Fri, 8 Nov 2024 17:32:08 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Using <br> instead of <div>, as suggested. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriter.java > line 605: > >> 603: //add the preview box: >> 604: section.add(HtmlTree.DIV(HtmlTree.BR())); >> 605: section.add(HtmlTree.DIV(HtmlTree.BR())); > > I just saw this in the generated HTML. Using `<br>` tags to add vertical > space is ok, but there's no need to put them inside a `<div>` element. Adding > only the `<br>` tags should have the same effect. Fixed in: https://github.com/openjdk/jdk/pull/21949/commits/0bb785132f0c8916c4ec7c8c69c56715d5b5a973. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21949#discussion_r1836104008
