On Mon, 11 Nov 2024 07:25:38 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be >> a new preview language feature: `requires transitive java.base;`. It would >> be good to show a warning box in the javadoc about the use of the feature. >> This PR is attempting to add such a warning box. >> >> Given it is likely this feature will either graduate or be dropped in the >> span of a few releases, I tried to make the code (relatively) easy to >> remove: it should be enough to delete the `if (javaBase != null && >> indirectPackages.keySet().contains(javaBase)) {` and the then section, >> keeping the else section + some slight cleanup. >> >> The new javadoc can be seen here: >> https://cr.openjdk.org/~jlahoda/8343752/updated/api/java.se/module-summary.html#preview-requires-transitive-java.base > > Jan Lahoda has updated the pull request incrementally with one additional > commit since the last revision: > > Removing divs, as suggested Looks good to me. ------------- Marked as reviewed by hannesw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21949#pullrequestreview-2429108522
