On Tue, 18 Feb 2025 14:53:49 GMT, Hannes Wallnöfer <[email protected]> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into snippet-non-rep
>> - adjusting error message
>> - Merge remote-tracking branch 'upstream/master' into snippet-non-rep
>> - emit error when encountering ambigious link
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/SnippetTaglet.java
> line 140:
>
>> 138: } else {
>> 139: Element e = null;
>> 140: String linkEncountered = null;
>
> Since the primary purpose of this variable is now to carry the link target
> (and checking for overlapping links is just a side-use) I would prefer
> something like `linkTarget` as name.
Hmm, I thought this means "the link you have encountered" and didn't raise a
point during review.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23328#discussion_r1960067318
