On Tue, 18 Feb 2025 14:41:17 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into snippet-non-rep >> - adjusting error message >> - Merge remote-tracking branch 'upstream/master' into snippet-non-rep >> - emit error when encountering ambigious link > > test/langtools/jdk/javadoc/doclet/ReproducibleSnippet/ReproducibleSnippetTest.java > line 70: > >> 68: src.toString(), >> 69: "p"); >> 70: checkExit(Exit.ERROR); > > The error message should also be checked. Fixed in [5325932](https://github.com/openjdk/jdk/pull/23328/commits/5325932671d4eebc90a6b0a166b0bc4e7705051e) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23328#discussion_r1963997300