On Tue, 4 Feb 2025 14:39:49 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> Please review this small update to make the test more robust, the test did > not always check links to other files if they did not contain a fragment or a > `#`symbol. > > I'd like to add that the original > [doccheck](https://github.com/openjdk/doccheck) also didn't pick up on these > missing files when I ran it. > > TIA test/docs/jdk/javadoc/doccheck/doccheckutils/checkers/LinkChecker.java line 227: > 225: && missingFiles == 0 > 226: && badSchemes == 0 > 227: && log.noErrors(); So we have both these counters and the `log` instance to track errors. Shouldn't the `missingIds` counter have bee increased when the error was logged? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23441#discussion_r1960166755
