On Thu, 5 Jun 2025 09:37:14 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - improve based on feedback >> - Merge branch 'master' into update-link-checker >> - Merge branch 'master' into update-link-checker >> - Merge branch 'master' into update-link-checker >> - update link checker to verify that files exist > > test/docs/jdk/javadoc/doccheck/doccheckutils/checkers/LinkChecker.java line > 223: > >> 221: @Override >> 222: public boolean isOK() { >> 223: return log.noErrors() && (missingFiles == 0); > > In method `reportMissingFile` where `missingFiles` is increased an error is > also logged, so I'm wondering is the `missingFiles` check needed here? I'd like to keep this extra check for safety for now. I plan on updating these tests again for JDK 26 (updating the external link checker) so I could do more cleanup then. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23441#discussion_r2128515936