Hi Marc and Rickard.

Guys,

I noticed that due to marc's change to make FastKey work, the
ContainerInvoker interface (and some others) was changed, replacing the
entity's pk for a FastKey instance, like where was

   public EJBObject getEntityEJBObject(Object id)
      throws RemoteException;

is now

   public EJBObject getEntityEJBObject(FastKey id)
      throws RemoteException;

Isnt't this an architecture tweak? An hack? Is it good to make the interface
domain-specific? Shoudn't we be keeping the "Object id" signature AND, in
our specific implementation (JRMP), checking at runtime if it is "instanceof
FastKey"?

Pardon me if my opinion feels like a pile of s**t to you - I'm not a jBoss
codebase guru (yet) anyway - but, however, this feels somewat wrong to me.
Any comments?

Hugo Pinto


Reply via email to