Hi!
Hugo Jos� Pinto wrote:
> I noticed that due to marc's change to make FastKey work, the
> ContainerInvoker interface (and some others) was changed, replacing the
> entity's pk for a FastKey instance, like where was
>
> public EJBObject getEntityEJBObject(Object id)
> throws RemoteException;
>
> is now
>
> public EJBObject getEntityEJBObject(FastKey id)
> throws RemoteException;
>
> Isnt't this an architecture tweak? An hack? Is it good to make the interface
> domain-specific? Shoudn't we be keeping the "Object id" signature AND, in
> our specific implementation (JRMP), checking at runtime if it is "instanceof
> FastKey"?
This is what I pointed to in my post: "Re: [jBoss-Dev] what is
fastCache". I don't agree with this change too. Should be Object, and
then cast to FastKey for our impl.
> Pardon me if my opinion feels like a pile of s**t to you - I'm not a jBoss
> codebase guru (yet) anyway - but, however, this feels somewat wrong to me.
> Any comments?
IMHO you're right on.
/Rickard
--
Rickard �berg
Email: [EMAIL PROTECTED]
http://www.telkel.com
http://www.jboss.org
http://www.dreambean.com
