Title: RE: [JBoss-dev] Are we logging the exception enough!!!
Well, IMHO, we should also find a way to remove all these redundant exceptions! Each level is printing the same exception, the same stack trace (with just a few line in less at each step...) When you *really* have more than one error, it is hard to differentiate them.
-----Message d'origine-----
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]De la part de Casey Haakenson
Envoyé : jeudi, 18 avril 2002 00:03
À : 'Jason Dillon'
Cc : [EMAIL PROTECTED]; 'marc fleury'; David Jencks; Scott M Stark
Objet : RE: [JBoss-dev] Are we logging the exception enough!!!

I attached before and after traces to the original message, but had mistakenly not saved the right after traces (was comparing initial startup and a redployment). 

Anyway, here are the right versions.

I'm not trying to show less info, just the same info in a slightly more intuitive layout.  In the case of the exception I was working on, "nested" only printed the name of the exception again "NullPointerException" which was already being printed by the stack trace.

-Casey



-----Original Message-----
From: Jason Dillon [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, April 17, 2002 2:26 PM
To: Casey Haakenson
Cc: [EMAIL PROTECTED]; 'marc fleury'; David
Jencks; Scott M Stark
Subject: Re: [JBoss-dev] Are we logging the exception enough!!!


>
> The second set of patches is for reformatting of the exception
> printing.  Dealing with it for a while, I just couldn't handle the way
> they were printed anymore so I changed it around a bit.  I realize
> this is mainly a personal preference, but I thought I'd send it out
> for feedback.  Outline of changes made:
>
> -Flipped the order NestedExceptions are printed in to be current
> exception first then sub-exception, and added a "Root Cause:" line
> above the sub-exception.  This way, when a user is reading the log
> from bottom to top, they see the sub-exception first (probably where
> the real problem is) and it's seperated from the above exception to
> provide a visual break.
>
> -Changed NestedThrowable.Util.getMessage() to not use "nested" in
> constructing the message.  It seemed to be only redundant info that
> was always printed out later on.  This change does scare me a bit in
> that I'm not sure what other code paths rely on info being included by
> "nested".  Any thoughts?
>

>

Please show examples for what the exception output will look like...
Looks like your patch to NestedThrowable only losses information... but
it is hard to tell.  Show me a before and after and why you think after
is better please =)

--jason


_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to