> -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] Behalf Of Hiram > Chirino > Sent: Friday, February 21, 2003 6:44 PM > To: [EMAIL PROTECTED] > Subject: RE: [JBoss-dev] TxInterceptor split is really really bad > > > > --- Bill Burke <[EMAIL PROTECTED]> wrote: > > > > > > > > > I would like to note that my future plans for this > > involve method specific > > > interceptor chains with a variety of "client side" > > and "server side" tx > > > interceptors, each one performing half of the > > TxSupport work. No maps, > > > just different specialized interceptors, with > > different interceptors per > > > method depending on the tx support. > > > > > > > Hmmmm...thanks for mentioning this. The AOP > > framework will have to change > > to support his type of per method intercepiton. > > > > Currently the ClassAdvisor asks the > > InterceptorFactory for an instance of an > > Interceptor and adds it to the interceptor chain. > > For what you want to do, > > this will have to change. The InterceptorFactory > > should be responsible for > > adding interceptors to the chain. Otherwise, my > > isolation and separation of > > metadata, interceptors, and pointcuts will be > > broken. > > > > I don't think that you model would be too broken. > His interceptors should only hav to implement the > org.jboss.aop.InvocationFilterInterceptor interface: > boolean intercepts(Invocation invocation); > > The org.jboss.aop.Invocation.invokeNext() will skip > over interceptors that do not interested the > invocation. Currently invokeNext() interogates the > intercetors on every invocation, but I think that we > should be able to keep a per Invocation interceptor > stack cache so that we can skip the interogation after > the first method call. >
That's not the issue. The issue is configuration. He wants to avoid sending over metadata about the method/tx bindings. TO do this he creates a Mandatory.java class and attaches it to the method. You see now? Actually David, you actually have almost the same memory footprint. WIthout per method , you have one instance of the Tx interceptor. WIth, you have an instance per interceptor. Almost the same as a hashmap of methodnames and strings identifying the tx attribute. Bill ------------------------------------------------------- This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. The most comprehensive and flexible code editor you can use. Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial. www.slickedit.com/sourceforge _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
