Please run the testsuite if you are going to make modifications to core parts of JBoss.
This change has enabled AttributeChangeNotifications for all standard mbeans, which means people will be receiving notifications they didn't expect. As was the case with some failing tests in the testsuite. On Sat, 2004-10-16 at 20:43, Dimitris Andreadis wrote: > User: andd > Date: 04/10/16 12:43:51 > > Modified: src/main/org/jboss/mx/modelmbean XMBean.java > Log: > update ModelMBeanInvoker notification listener registry, even if the > target resource is a NotificationBroadcaster, so that the XMBean's > own AttributeValueChanges, still work. > > Revision Changes Path > 1.29 +9 -6 jmx/src/main/org/jboss/mx/modelmbean/XMBean.java > > Index: XMBean.java > =================================================================== > RCS file: /cvsroot/jboss/jmx/src/main/org/jboss/mx/modelmbean/XMBean.java,v > retrieving revision 1.28 > retrieving revision 1.29 > diff -u -r1.28 -r1.29 > --- XMBean.java 10 Aug 2004 22:57:04 -0000 1.28 > +++ XMBean.java 16 Oct 2004 19:43:51 -0000 1.29 > @@ -397,8 +397,9 @@ > // StandardMBeans and resources who implement NotificationBroadcaster > if (resourceType.equals(STANDARD_MBEAN) || getResource() instanceof > NotificationBroadcaster) > addNotificationListenerToResource(listener, filter, handback); > - else > - super.addNotificationListener(listener, filter, handback); > + > + // update our listener registry anyway so that our AVCs still work > + super.addNotificationListener(listener, filter, handback); > } > > public void removeNotificationListener(NotificationListener listener) > @@ -407,8 +408,9 @@ > // StandardMBeans and resources who implement NotificationBroadcaster > if (resourceType.equals(STANDARD_MBEAN) || getResource() instanceof > NotificationBroadcaster) > removeNotificationListenerFromResource(listener); > - else > - super.removeNotificationListener(listener); > + > + // update our listener registry anyway so that our AVCs still work > + super.removeNotificationListener(listener); > } > > public void removeNotificationListener(NotificationListener listener, > @@ -419,8 +421,9 @@ > // StandardMBeans and resources who implement NotificationBroadcaster > if (resourceType.equals(STANDARD_MBEAN) || getResource() instanceof > NotificationBroadcaster) > removeNotificationListenerFromResource(listener, filter, handback); > - else > - super.removeNotificationListener(listener, filter, handback); > + > + // update our listener registry anyway so that our AVCs still work > + super.removeNotificationListener(listener, filter, handback); > } > > public MBeanNotificationInfo[] getNotificationInfo() > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: IT Product Guide on ITManagersJournal > Use IT products in your business? Tell us what you think of them. Give us > Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more > http://productguide.itmanagersjournal.com/guidepromo.tmpl > _______________________________________________ > jboss-cvs-commits mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/jboss-cvs-commits -- xxxxxxxxxxxxxxxxxxxxxxxx Adrian Brock Director of Support Back Office JBoss Inc. xxxxxxxxxxxxxxxxxxxxxxxx ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ JBoss-Development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
