On Dec 19, 2011, at 3:33 PM, Kelly O'Hair wrote: > > Need reviewer for some sanity check fixes for jdk7u-osx (Mac) > > 7123022: Fixing some Mac sanity checks > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-jdk-sanity/webrev/
Looks good to me, except: + REQUIRED_COMPILER_NAME = GCC4 + REQUIRED_COMPILER_VERSION = GCC4 The JDK should be buildable under both llvm-gcc (which it currently uses) and clang, which is the future, since llvm-gcc is now in maintenance mode. If you are restricting your builders to Mac OS X 10.7 now, you can actually cut over to using clang soon, since it has no known bugs compiling the JDK (right Alex? I'm not completely hallucinating this right?) Regards, Mike Swingler Apple Inc.
