On 10/05/2012 6:34 PM, Henri Gomez wrote:
The setting of the os.arch property in
src/solaris/native/java/lang/java_props_md.c should be handled by setting
ARCHPROP appropriately in jdk/make/common/Platform.gmk, not by ifdefs in the
C file.
yes, but ARCHPROP is set to universal so 32 and 64 builds are performed.
So there is really 2 copy of
src/solaris/native/java/lang/java_props_md.c in binary, one for 32bits
and one for 64bits.
I don't really understand the above. java_props_md.c must be compiled
separately for a 32-bit and 64-bit build. So in the 32-bit build
ARCHPROP should be set to i386, and in a 64-bit build it should be set
to x86_64. LIBARCH might be "universal" in both cases (is it?) but
ARCHPROP should reflect the actual value you want os.arch to report.
Sorry if I'm misunderstanding the nuances of universal builds.
Note, it was the way macosx-port did it before all universal support
was removed in jdk7 branch ;(
Yes, well the macosx port did a lot of things in ways that were less
than desirable. A little got fixed for 7, a little more for 8.
David
-----
Can't comment on anything else as I don't grok this "universal" build
business.
May be Mike or Scott, OSX experts, may take a look.
This feature is highly awaited by OSX users, they used to have a dual mode VM.
Simple question, did there is any interest here to support universal VM on OSX ?
If not, I'll continue to maintain this patch and produce packages in
such mode, but I think we all agree that It won't be good for OpenJDK
for OSX to have various distributions with different behaviors and
functionalities.
