%if %option_with_indiana_branding
  %patch29 -p1
  %endif

Now it should be
patch17 -p1

Others look fine.

That's why we don't want to re-number patches for every time.
It's very easy to make mistakes because Firefox has quite a few patches.
And unlike GNOME projects, we have to maintain patches for several  
branches.
For Firefox, I prefer do re-numbering every a few months.

Ginn

On May 19, 2009, at 11:31 PM, krishnan parthasarathi - Sun  
Microsystems - Bangalore India wrote:

> <8586-patches-grp.diff>

--------
Ginn Chen
Software Engineer, Browser Team
Sun Microsystems, Inc.
Phone: x82869 / +86-10-62673869
Fax: +86-10-62780969


-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20090520/33606198/attachment.html>
  • [jds-review] R... krishnan parthasarathi - Sun Microsystems - Bangalore India
    • [jds-revi... Brian Cameron
      • [jds-... krishnan parthasarathi - Sun Microsystems - Bangalore India
        • [... Ginn Chen
          • ... krishnan parthasarathi - Sun Microsystems - Bangalore India
            • ... Ginn Chen

Reply via email to