The patch attached is modified to include changes Ginn has pointed out. I have also avoided renumbering the patches as per Ginn's advice.
Krishnan On Wed, 2009-05-20 at 12:39 +0800, Ginn Chen wrote: > %if %option_with_indiana_branding > %patch29 -p1 > %endif > > > Now it should be > patch17 -p1 > > > Others look fine. > > > That's why we don't want to re-number patches for every time. > It's very easy to make mistakes because Firefox has quite a few > patches. > And unlike GNOME projects, we have to maintain patches for several > branches. > For Firefox, I prefer do re-numbering every a few months. > > > Ginn > > > On May 19, 2009, at 11:31 PM, krishnan parthasarathi - Sun > Microsystems - Bangalore India wrote: > > > <8586-patches-grp.diff> > > -------- > Ginn Chen > Software Engineer, Browser Team > Sun Microsystems, Inc. > Phone: x82869 / +86-10-62673869 > Fax: +86-10-62780969 > > > -------------- next part -------------- A non-text attachment was scrubbed... Name: 8586.diff Type: text/x-patch Size: 41772 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20090520/43b7a634/attachment.bin>
