Alan: I agree it makes sense to move this to spec-files. The spec-file looks good. However, the %files sections are a bit cumbersome. We normally use wildcards or just specify directories, rather than specify each file. Especially for private directories where the contents can change but it isn't so important to track, or for directories where we add files since we know the contents.
Brian > As I've discussed with several people, and proposed to the C-Team, > here's a first draft of a conversion of the current xscreensaver 5.01 > sources from the X gate to a spec file for the GNOME gate. > > For this initial version, I've stuck with the current state of the code > as is (well, it reflects the update of rss-glx to the new 0.9.0 release > that's in my workspace getting ready for putback to X, since they accepted > all our upstreamable patches into that release, so it's a simpler port). > It most especially does not upgrade xscreensaver from 5.01 to a later > release (5.08 is the latest upstream, but upstream had a complete PAM > rewrite in 5.02, which while much better, is much different and would > require a lot of work to resync with our PAM/gtk-lock/auditing/Trusted > changes). > > The patches came across mostly as is, just renamed to match the spec > file naming style, and with a few fuzzing errors cleaned up. > > The one big change I've made from the X gate is a bit of package > renaming/refactoring. > > In X the packages are currently: > SUNWxwsvr - core xscreensaver daemon & utilities > SUNWxscreensaver-hacks - non-OpenGL hacks > SUNWxscreensaver-hacks-gl- OpenGL hacks, including rss-glx > SUNW0xwsvr - l10n template delivered to g11n > SUNW*xwsvr - l10n packages delivered by g11n > > In this spec file, the packages are: > SUNWxscreensaver - core xscreensaver daemon & utilities > SUNWxscreensaver-hacks - non-OpenGL hacks > SUNWxscreensaver-hacks-gl - OpenGL hacks from xscreensaver > SUNWrss-glx - OpenGL hacks from rss-glx > SUNWxscreensaver-l10n - l10n package built from this spec > SUNWxwsvr - backwards compatibility links in /usr/openwin > > I've tried to copy the examples I saw of handling the l10n packaging > with the upstream code, but expect the g11n team will have to look at > merging this with the existing SUNW*xwsvr packages and figure out which > way they want to go. > > At this point, the spec file builds & installs packages which seem to > work in a quick test via the screensaver control panel, so I'm looking > for feedback on how badly I failed to follow the normal GNOME spec file > rules/patterns/conventions and any suggestions for improvements from those > who have done a few more of these than I. (This is my first official spec > file! Please assume anything I got wrong is out of ignorance and help me > get this better for all our sakes.) > > The spec file itself is attached. To avoid mailbox explosions, the 47 > patches > and various other assorted files are posted at: > http://cr.opensolaris.org/~alanc/xscreensaver/ > both individually and in a single tarball if you want to try building > yourself. > > I'd like to see if we can get this into the vermillion builds for 117 or 118, > let it get tested/soaked there for a couple builds, then coordinate a push > from > vermillion to the Nevada branch at the same build we stop building in the X > gate. > > Once 5.01 is in stable/nevada, then I'd be more willing to discuss > bigger/riskier changes to the vermillion branch version. > >
