Hi Alan,
On Thu, 2009-05-21 at 23:41 -0700, Alan Coopersmith wrote:
> At this point, the spec file builds & installs packages which seem to
> work in a quick test via the screensaver control panel, so I'm looking
> for feedback on how badly I failed to follow the normal GNOME spec file
> rules/patterns/conventions and any suggestions for improvements from those
> who have done a few more of these than I. (This is my first official spec
> file! Please assume anything I got wrong is out of ignorance and help me
> get this better for all our sakes.)
Well written spec file.
Just a couple of comments:
> %package -n SUNWxwsvr
> Summary: %{summary} - /usr/openwin compatibility links
> SUNW_BaseDir: %{_basedir}
...
> %description
> Backwards compatibility links for old paths under /usr/openwin for
> XScreenSaver
> files.
The descriptions (although not currently used for either SVr4 or
IPS packages), should be linked to the packages:
%description -n SUNWxwsvr
The other comment is that we generally prefer -p1 patches, but
I realise it's a pain to convert 45 patches...
Laca
