On 03/13/09 17:53, Joerg Schilling wrote: > Jerry Tan <Jerry.Tan at sun.com> wrote: > > >>> If I did not miss something, you completely removed the >>> --output-endianess=little option, this will cause it to fail on Intel >>> hardware. >>> >>> Cdda2wav by default always outputs data in network byte order. >>> >>> If you request raw audio data, it is a good idea to write interfaces the >>> same >>> way and convert byte order lately before it is send to the driver (in case >>> the >>> driver is not able to do this abstraction from machine byte order). >>> >>> J?rg >>> >>> >>> >> Yes, that's what the patch try to do. >> remove "--output-endianess=..." >> > > Then the patch breaks things on x86. > > J?rg > > so I have to add #ifdef __sparc here?
-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20090313/763e484f/attachment.html>
