Alan/Takao: > Other specific comments: > >> + echo "This script is not designed to run directly." >> + echo "Please use /etc/X11/gdm/Xsession instead."
Note that /etc/X11/gdm/Xsession should only be run if the user is using the GDM display manager. Perhaps the comment should highlight this? > If it's not designed to be run directly, it shouldn't be in /usr/bin The dtstart script now no longer does seems to do anything except translate "jds" to "/usr/bin/gnome-session". I think it be better to just get rid of the dtstart script altogether and also get rid of the gnome-session-06-Xsession-dtstart.diff and the gnome-session-07-Xsession.diff patches and just let gnome-session be run directly from the /etc/X11/gdm/Xsession script when using GDM. What do you think? Since CDE login doesn't use the /usr/share/xsessions/gnome.desktop file, this shouldn't have any impact on CDE login. However, if there is some reason we need the dtstart script that I am missing, then perhaps /etc/X11/init be a better directory to install it. It's intended to be a general interface that could be used by any display manager (though we will not likely enhance CDE login to make use of the /etc/X11/init interfaces). If we want to provide a "recommended command" in the dtstart script to start GNOME, it should probably be the following instead of just telling them to run the Xsession script with no arguments. /etc/X11/gdm/Xsession /path/to/dtstart $SESSION_NAME Where $SESSION_NAME could be "jds" to start GNOME, for example. Brian
