Brian Cameron-san wrote (02/ 5/09 10:10 AM): >> I created the patch for xinitrc.d however I'm not sure how is the packaging. >> Can you replace SUNWgnome-dtstart in Indiana?
I meant if we change the package name for Indiana. My understanding is there is a special request for Indiana RE. > > Note that when using CDE login this directory of scripts is sourced: > > - /usr/dt/config/Xsession.d > > When using GDM this directory of scripts is sourced: > > - /etc/X11/xinit/xinitrc.d > > I don't think the SUNWdtlogin-integration package is a good place > to install GDM-specific startup scripts. The SUNWdtlogin-integration > package is instead for CDE specific integration files. If you look at the spec file, I added SUNWdesktop-startup package newly in SUNWdtlogin-integration.spec. /usr/dt/config/Xsession.d is added to SUNWgnome-dtlogin-integration package. /etc/X11/xinit/xinitrc.d and dtstart are added to SUNWdesktop-startup package. Does it make sense? > > Since /etc/X11/xinit/xinitrc.d is supposed to be a display-manager > neutral directory, it might make sense to install these scripts (and the > dtstart script) via a new package. Perhaps SUNWxinitrc-scripts or > something would be a good neutral name. > > I guess I don't understand the need for the > SUNWgnome-dtlogin-integration-01-migration.diff patch. Why are we > changing how CDE login integration works at all? Now the scripts are moved into /usr/dt/config/Xsession.d. So SUNWgnome-dtlogin-integration has the duplicated part. This patch removes the duplicated part. > > If you do remove this code from the CDE Xinitrc.jds script, then > don't you also need to modify or add some new scripts to the > /usr/dt/config/Xsession.d directory? After all, the scripts > you are adding to /etc/X11/xinit/xinitrc.d won't get sourced when > CDE login is used. I put the scripts in both Xsession.d and xinitrc.d. The sessions from dtlogin loads the scripts under Xsession.d. The sessions from GDM loads the same scripts under xinitrc.d. > > I would think we would just leave the CDE login integration stuff alone, > and let it go away when CDE login is EOL'ed. This shouldn't be called > at all anymore when using GDM, right? > > Also, I would expect that the default /etc/gdm/Xsession script > would need to be modified in conjunction with this change. I believe > some of the code in the /etc/gdm/Xsession script has now been moved > to /etc/X11/xinit/xinitrc.d. No? So I'm surprised to not see another > patch to remove the code from /etc/gdm/Xsession that is no longer > needed. Yes, I'll try to modify /etc/gdm/Xsession. Since several parts are modified, I'd wanted the feedback before we'll modify GDM. fujiwara > > Brian > >
