Takao: >> I'd think it would be better to create separate spec files for each >> package. Building different packages via %if statements in the >> same spec-file seems really confusing to me. > > I think %if statements won't be shown if we rename SUNWgnome-dtstart to > SUNWdesktop-startup. > Is it better to separate the spec files even though some scripts are > installed in both Xsession.d and xunitrc.d?
I think it is not a problem for multiple packages to install the same scripts to different directories. One package installs them to the CDE location, and the other to the GDM location. Note that there will only be one copy of the scripts in the ext-sources directory. >> Okay, I understand now. Looking back over your diff, what you are >> proposing for the /usr/dt/config/Xsession.d directory looks wrong to me. >> Note that /usr/dt/config/Xsession.d already contains the following >> scripts and these scripts are owned by the CDE project, not the GNOME >> project: >> >> 0005.dbus >> 0010.dtpaths >> 0015.sun.env >> 0020.dtims >> 0030.dttmpdir >> 0040.xmbind >> 1099.br >> >> Doesn't your new 0010.env script conflict with the existing 0010.dtpaths >> script. Why do both use the same 0010 number? Likewise your >> 0020.dtims conflicts with the script of the same name shipped with CDE? >> Ditto for 0030.dttmpdir, 0040.xmbind, and 1099.br scripts. > > It's a good point I forgot. > 0020.dtims is kept in Xsession.d and 0210.im won't be installed in Xsession.d. > Probably I think 0010.env will be renamed to 0011.env As I said, there is no problem with adding new scripts to the /usr/dt/config/Xsession.d directory. However, if you want to modify how the existing scripts in that directory work, then I'd file a bug against CDE login and see if we can get the maintainer to update them. >> If you want to change these scripts you should probably be coordinating >> with the CDE team to replace them with your improved scripts. Trying >> to add them in the SUNWdtlogin-integration package is the wrong place. >> >> As I said before, it might be best to just not make any changes to >> /usr/dt/config/Xsession.d and let it just go away when CDE login >> is EOL'ed and removed. >> >> If you want to make some cleanup in SUNWdtlogin-integration, then it >> is probably okay if you add new scripts to /usr/dt/config/Xsession.d >> to add anything that is missing. For example, if you want to move some >> logic from the Xinitrc.jds script to a new /usr/dt/config/Xsession.d >> script. But doing any coordination with the CDE team to replace the >> scripts owned by the CDE team would not be worth the work, I think. >> >> What do you think? > > Yes, we don't have to ask CDE team. We modify JDS scripts only. > I'd like to consolidate scripts. I agree that would be nice, if we can get the CDE mainatiner to help update them. Though, I suspect there will be pushback unless updating the scripts fixes some serious issues. If we find we cannot update the CDE scripts, then I don't think this is a big problem. Remember CDE login is being EOL'ed, and these scripts should hopefully go away soon anyway. In my opinion, fixing the CDE scripts owned by the CDE team is a nice-to-have, and probably not critical. Though, adding new scripts that only impact the SUNWdtlogin-integration package is probably okay. In other words, moving code from the Xinitrc.jds script to a /usr/dt/config/Xsession.d script is not a problem since our team owns the SUNWdtlogin-integration package. Brian
