Hi Laca, Laszlo (Laca) Peter wrote: > Do you guys have a code review process in place for the code itself? > Bumping the tarball version doesn't tell much about the code changes. >
I included the diffs for the actual code changes in the review mail I sent out.. But presumably bumping the tarball is preferable to accumulating patches in spec-files-other? Niall > Laca > > >> Index: core/SUNWgnome-time-slider.spec >> =================================================================== >> --- core/SUNWgnome-time-slider.spec (revision 645) >> +++ core/SUNWgnome-time-slider.spec (working copy) >> @@ -15,7 +15,7 @@ >> >> Name: SUNWgnome-time-slider >> Summary: Time Slider ZFS snapshot management for GNOME >> -Version: 0.2.4 >> +Version: 0.2.5 >> Source: >> http://dlc.sun.com/osol/jds/downloads/extras/time-slider/time-slider-%{version}.tar.bz2 >> SUNW_BaseDir: %{_basedir} >> SUNW_Copyright: %{name}.copyright >> @@ -123,6 +123,8 @@ >> %endif >> >> > > >
