Hi Laca,
Laszlo (Laca) Peter wrote:
> On Mon, 2009-02-09 at 09:44 +0000, Niall Power wrote:
>
>> Hi Laca,
>>
>> Laszlo (Laca) Peter wrote:
>>
>>> Do you guys have a code review process in place for the code itself?
>>> Bumping the tarball version doesn't tell much about the code changes.
>>>
>>>
>> I included the diffs for the actual code changes in the review mail
>> I sent out..
>>
>
> Ah, sorry... there was some noise at the end of the diff and I
> scrolled through too quickly...
>
>
>> But presumably bumping the tarball is preferable to accumulating
>> patches in spec-files-other?
>>
>
> Depends. For tiny changes it may be better to add a patch and
> fix the same thing in svn/hg. Ask Stephen :)
>
> BTW, now that I found the diff:
>
> +PYTHON = /usr/bin/python
>
> Please use a versioned python interpreter, i.e. /usr/bin/python2.4
> Even better, make it configurable so we only need to change the spec
> file when we switch from 2.4 to 2.6.
>
OK. I've listed a diff below that exports PYTHON from the spec file
and gets picked up in time-slider's Makefile:
Makefile:
> diff -r 6a7d94810fb1 Makefile
> --- a/Makefile Thu Feb 05 13:21:33 2009 +0000
> +++ b/Makefile Wed Feb 11 10:58:46 2009 +0000
> @@ -5,10 +5,14 @@
> INSTALL_DATA = ${INSTALL} -u root -g bin -m 644 -f
> INSTALL_PROGRAM = ${INSTALL} -u root -g bin -f
> INSTALL_SCRIPT = ${INSTALL} -f
> -PYTHON = /usr/bin/python
> RM = /usr/bin/rm -f
> RMRF = /usr/bin/rm -Rf
> RMDIR = /usr/bin/rmdir
> +# Use python 2.4 if PYTHON environent is not set
> +ifeq ($(strip $(PYTHON)),)
> +PYTHON = /usr/bin/python2.4
> +endif
> +
> SUBDIRS = po data
>
> DISTFILES = Authors \
SUNWgnome-time-slider.spec:
--- SUNWgnome-time-slider.spec (revision 663)
+++ SUNWgnome-time-slider.spec (working copy)
@@ -47,6 +47,7 @@
%setup -q -n time-slider-%{version}
%build
+export PYTHON="/usr/bin/python2.4"
make
%install
---------------------
If you're ok with these changes I'll add a patch for the Makefile
Cheers,
Niall.
> Laca
>
>
>
