> # date:2008-09-05 owner:lin type:feature
> Patch1:                  brasero-01-allinone.diff
> # date:2008-09-05 owner:lin type:branding
> Patch2:                  brasero-02-manpages.diff

Can you attach these patches, please?
And the copyright file as well.

> # need a patch here
> #cd data
> #sed -e 's:Exec=brasero:Exec=gksu brasero:' brasero.desktop.in.in >
> tmp.$$
> #mv tmp.$$ brasero.desktop.in.in

??

> %build

> export CFLAGS="%optflags"
> export LDFLAGS="%_ldflags"

> %if %cc_is_gcc
> %else
> export CXX="${CXX} -norunpath"
> %endif

If it includes C++ code, you need to set CXXFLAGS="%{_cxx_optflags}"
as well.

> ./configure --prefix=%{_prefix} --mandir=%{_mandir} \
>         --libdir=%{_libdir}             \
>         --libexecdir=%{_libexecdir}     \
>         --sysconfdir=%{_sysconfdir}     \

>         --disable-gnome2                \

what does this do?

> rm -f $RPM_BUILD_ROOT%{_libdir}/brasero/plugins/libbrasero-toc2cue.so
> rm -f $RPM_BUILD_ROOT%{_libdir}/brasero/plugins/libbrasero-cdrdao.so

Why?  (Please add a comment in the spec file)


> ???%files
> 
> # %dir %attr(0755, root, bin) %{_datadir}/omf
> # %{_datadir}/omf/*

> # %dir %attr(0755, root, other) %{_datadir}/gnome
> # %dir %attr(0755, root, bin) %{_datadir}/gnome/help
> # %{_datadir}/gnome/help/*

Please delete the commented lines.

> %files root
> %defattr (0755, root, sys)
> %attr (0755, root, sys) %dir %{_sysconfdir}
> %{_sysconfdir}/gconf/schemas/brasero.schemas

You forgot the %post root and %postun root scripts for
installing/uninstalling these schemas.

Laca



Reply via email to