Laszlo (Laca) Peter wrote:
>> # date:2008-09-05 owner:lin type:feature
>> Patch1: brasero-01-allinone.diff
>> # date:2008-09-05 owner:lin type:branding
>> Patch2: brasero-02-manpages.diff
>>
>
> Can you attach these patches, please?
> And the copyright file as well.
>
Sorry I spent lots of time on vermillion 99 update by ips. They are
attached now.
The copyright is still in old fashion.
>
>> # need a patch here
>> #cd data
>> #sed -e 's:Exec=brasero:Exec=gksu brasero:' brasero.desktop.in.in >
>> tmp.$$
>> #mv tmp.$$ brasero.desktop.in.in
>>
>
> ??
>
I will remove these lines.
>
>> %build
>>
>
>
>> export CFLAGS="%optflags"
>> export LDFLAGS="%_ldflags"
>>
>
>
>> %if %cc_is_gcc
>> %else
>> export CXX="${CXX} -norunpath"
>> %endif
>>
>
> If it includes C++ code, you need to set CXXFLAGS="%{_cxx_optflags}"
> as well.
>
No c++ code, I copied those lines, will remove them.
>
>> ./configure --prefix=%{_prefix} --mandir=%{_mandir} \
>> --libdir=%{_libdir} \
>> --libexecdir=%{_libexecdir} \
>> --sysconfdir=%{_sysconfdir} \
>>
>
>
>> --disable-gnome2 \
>>
>
> what does this do?
>
It will build brasero help. But there are bugs here will cause build to
fail. So I disable it temporary.
>
>> rm -f $RPM_BUILD_ROOT%{_libdir}/brasero/plugins/libbrasero-toc2cue.so
>> rm -f $RPM_BUILD_ROOT%{_libdir}/brasero/plugins/libbrasero-cdrdao.so
>>
>
> Why? (Please add a comment in the spec file)
>
According to ARC, we do not ship them. A comment is OK, I will add it.
>
>
>> ???%files
>>
>> # %dir %attr(0755, root, bin) %{_datadir}/omf
>> # %{_datadir}/omf/*
>>
>
>
>> # %dir %attr(0755, root, other) %{_datadir}/gnome
>> # %dir %attr(0755, root, bin) %{_datadir}/gnome/help
>> # %{_datadir}/gnome/help/*
>>
>
> Please delete the commented lines.
>
I commented out those lines because --disable-gnome2. I think leave it
there is OK, since it will be fixed finally.
>
>> %files root
>> %defattr (0755, root, sys)
>> %attr (0755, root, sys) %dir %{_sysconfdir}
>> %{_sysconfdir}/gconf/schemas/brasero.schemas
>>
>
> You forgot the %post root and %postun root scripts for
> installing/uninstalling these schemas.
>
OK, will add them.
lin
--
x82120 / +86 10 82618200
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: brasero-01-allinone.diff
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080910/53fe47f7/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: brasero-02-manpages.diff
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080910/53fe47f7/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SUNWbrasero.copyright
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080910/53fe47f7/attachment-0002.ksh>
