Hi Laca, Some error for the previous spec. resent it here.
Best, -Alfred Alfred Peng wrote: > Hi Laca, > > Thanks for the review. Update the spec as attached. > > Laszlo (Laca) Peter wrote: >> Alfred, >> >> What Ginn said, plus some more comments inline: >> >> On Wed, 2008-07-16 at 23:14 +0800, Alfred Peng wrote: >> >>> Requires: SUNWpcre >>> Requires: SUNWgnome-spell >>> Requires: SUNWgnome-libs >>> BuildRequires: SUNWgnome-libs-devel >>> Requires: SUNWlibC >>> >> >> Is it C++ code? Do you need to define CXXFLAGS? >> > It's only C code. Get rid of CPPFLAGS. >> Also, you need a dependency on SUNWpostrun since you use a >> postrun script. >> >> >>> export CFLAGS="%optflags -I/usr/gnu/include -I/usr/sfw/include >>> -DANSICPP" >>> export CPPFLAGS="-I/usr/sfw/include" >>> export LDFLAGS="-L/usr/sfw/lib -R/usr/sfw/lib -L/usr/gnu/lib >>> -R/usr/gnu/lib" >>> >> >> Does it actually use anything that is still in /usr/sfw? >> It's mostly empty now with just compatibility symlinks. >> > Remove all /usr/sfw usage. >>> bluefish-1.0.5/data/Makefile.in.orig 2006-02-10 18:03:19.392428000 >>> +0000 >>> +++ bluefish-1.0.5/data/Makefile.in 2006-02-10 18:13:28.694247000 >>> +0000 >>> @@ -58,14 +58,14 @@ >>> $(INSTALL_DATA) bluefish-project.desktop $(DESTDIR)$(FDMENU) >>> >>> install-update-menu: >>> - $(UPDATE_DESKTOP) >>> + # $(UPDATE_DESKTOP) >>> >>> install-fdmime: >>> $(INSTALL_DIR) $(DESTDIR)$(FDMIME)/packages >>> $(INSTALL_DATA) bluefish.xml $(DESTDIR)$(FDMIME)/packages >>> >>> install-update-mime: >>> - $(UPDATE_MIME) $(FDMIME) >>> + # $(UPDATE_MIME) $(DESTDIR)$(FDMIME) >>> >>> install-gnome-2.4-mime: >>> $(INSTALL_DIR) $(DESTDIR)$(GMIMEINFO) >>> >> >> There is often a configure option for disabling this -- you >> shouldn't need to patch it. > Configure option --disable-update-databases fits good here. > > Best, > -Alfred -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: SUNWbluefish.spec URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080721/2dd47812/attachment.ksh>
