On Jul 22, 2008, at 10:10 AM, Alfred Peng wrote:

>>   Perhaps the pcre stuff should be
>> "#ifdef sun" or the configure script should check if pcre is on the
>> system and add the #includes if so?
>> +if pkg-config libpcre --atleast-version=7.4 ; then
>> ......
>> +else
>> +    AC_MSG_ERROR(libpcre 7.4 missing please install it)
>> fi
>>
> The code snippet above is to check whether libpcre is on the system.


I think it should something like
If it has PCRE_CONFIG then
   LIBS="$LIBS `PCRE_CONFIG --libs`"
   CFLAGS="$CFLAGS `$PCRE_CONFIG --cflags`"
else if pkg-config libpcre --atleast-version=7.4 ; then
   LIBS="$LIBS `pkg-config --libs libpcre`"
   CFLAGS="$CFLAGS `pkg-config --cflags libpcre`"
else
   AC_MSG_ERROR(...)

Then it can go upstream.

Ginn

--------
Ginn Chen
Software Engineer, Browser Team
Sun Microsystems, Inc.
Phone: x82869 / +86-10-62673869
Fax: +86-10-62780969


-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080722/7bccbdc4/attachment.html>

Reply via email to