Patrick:

> I think I fixed it. It surely won't win the coding beauty contest but
> at least I'm able to build and install SUNWgnome-a11y-gok atfer three
> weeks or so ;-)

This is some progress, but I think the patch is wrong.

First of all, we normally do not patch Makefile.in files.  Instead we
patch Makefile.am, and the Makefile.in file should get built via running
automake then configure.

It seems the old GOK installed the kbd files directly to /usr/share/gok
and not /usr/share/gok/C.  Is the fact that these files moved (or are
perhaps gettings installed to two locations) an artifact of your patch?

> --- gok-1.3.7/Makefile.in.orig        2008-01-14 16:40:20.919634729 +0100
> +++ gok-1.3.7/Makefile.in     2008-01-14 16:40:25.098319904 +0100
> @@ -572,10 +572,16 @@
>       @$(NORMAL_INSTALL)
>       test -z "$(xmldir)" || $(mkdir_p) "$(DESTDIR)$(xmldir)"
>       @list='$(xml_DATA)'; for p in $$list; do \
> -       if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \
>         f=$(am__strip_dir) \
> +       if [ -z $$d ]; then /bin/true ; else \

Above, you remove the line which sets variable %d, so it does not seem
to make sense to check the variable $$d here.  Or am I missing
something?

>         echo " $(xmlDATA_INSTALL) '$$d$$p' '$(DESTDIR)$(xmldir)/$$f'"; \
>         $(xmlDATA_INSTALL) "$$d$$p" "$(DESTDIR)$(xmldir)/$$f"; \
> +          fi; \
> +     done
> +     for z in $(srcdir)/*.xam; \
> +     do \
> +             echo "$(xmlDATA_INSTALL) $$z $(DESTDIR)$(xmldir)/$$z"; \
> +             $(xmlDATA_INSTALL) $$z $(DESTDIR)$(xmldir)/$$z; \
>       done

Why do we need the 2nd for loop.  What aren't the *xam files just 
included in xml_DATA?

Brian

Reply via email to