On Jan 14, 2008 11:06 PM, Brian Cameron <Brian.Cameron at sun.com> wrote:
>
> Patrick:

> Your usage of Makefile.in versus Makefile.am is confusing.  I think you
> mean to say "The only thing I see in Makefile.am with similar..." and I
> think you mean to say "why I hacked the Makefile.in and not the
> Makefile.am".

Yeah, this doesn't really deserve the euro-vision-explaining price,
haha! Well it could be worse, normaly in these situations I start
talking about "thingies" and "stuff". But yeah, you're right, what you
think I meant to say is correct. ;-)

> Anyway, just to be clear, you should be working to fix this by
> editing the Makefile.am.

Understood. Cheers :)

> If I were to guess, the way xml_DATA is being set-up in Makefile.am
> is probably incorrect.  Or perhaps these files really shouldn't
> be considered "xml_DATA" and should instead some other type should
> be used for kbd files.

The kbd files are, in fact XML documents. So I guess it can be alright.
   $ file launcher.kbd
   launcher.kbd:   XML document

>
> To fix this you probably need to learn about automake.  Fixing bugs
> in how Makefile.am files are translated to Makefile.in files are
> often hard.
>
>    http://sources.redhat.com/automake/automake.html

Never said no to a challange ;-)
This will be a project for during the weekends mainly though. I have
one hour in the train from/to work and the trains back are mostly
packed due rush hour. Next to that I have a friend working at RedHat
(Nashua area) so maybe he can help me explaining stuff a bit more.

>
> A hack that modifies Makefile.in is useful for testing and perhaps
> getting an understanding of the problem, but is likely not the right
> fix.

Oh no doubt! It's really just that this package didn't build for.. I
dunno, three weeks? And it annoyed me, so I thought I work on it a bit
to see what was going on. It's a good learning project and not too
much seems to be impacted by it not working anyway, so :)
But yeah, this was the dirty hack, now we need some saner hack, I'll
do my best. Of course if one of you guys/girls fixes it before, I can
always look at the diffs to see what you did and learn from that :)

Take care now!
>
> Brian
>

Patrick

Reply via email to