Patrick:

> You're right (duh). The catch was that the build failed when I was
> building --without gtk-doc. I tried my patch, rebuild, but without
> --without gtk-doc. So it was "fixed".
> Real problem is a missing if-block in the %install area where the
> gtk-doc directory isnt removed when compiling with --without gtk-doc.
> 
> I will revert my changes to the prototype and commit the patch
> mentioned below. I also tried to build --with gtk-doc. This still
> works correctly.

Again, I'm confused by this patch.  It doesn't look like any other
spec-files use this sort of technique.  We should keep all our spec
files (that build gtk-docs) consistent.  Not change one to do
something special like this.  If this is really needed, we should
add it to all the spec-files that build gtk-docs.

Brian


> --- base-specs/glade.spec       (revision 12892)
> +++ base-specs/glade.spec       (working copy)
> @@ -85,6 +85,11 @@
>  find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';'
>  find $RPM_BUILD_ROOT -type f -name "*.a" -exec rm -f {} ';'
> 
> +%if %{!?_without_gtk_doc:0}%{?_without_gtk_doc:1}
> +rm -rf $RPM_BUILD_ROOT%{_datadir}/gtk-doc
> +%endif
> +
> +
>  %clean
>  rm -rf $RPM_BUILD_ROOT


Reply via email to