On Jan 28, 2008 10:22 PM, Brian Cameron <Brian.Cameron at sun.com> wrote: > Patrick: > > > You're right (duh). The catch was that the build failed when I was > > building --without gtk-doc. I tried my patch, rebuild, but without > > --without gtk-doc. So it was "fixed". > > Real problem is a missing if-block in the %install area where the > > gtk-doc directory isnt removed when compiling with --without gtk-doc.
> > Again, I'm confused by this patch. It doesn't look like any other > spec-files use this sort of technique. We should keep all our spec > files (that build gtk-docs) consistent. Not change one to do > something special like this. If this is really needed, we should > add it to all the spec-files that build gtk-docs. > Without the patch I made you will get an error that there are unpackaged files when you build --without gtk-doc. These two spec files I wrote a patch for are the only packages that had these problems (I did a pkgtool build --without gtk-doc *.spec) It's not so much that the build fails or that the packages don't get created. They just don't get installed automaticly because in the BUILD area there are files in /usr/share/gtk-doc that don't get packaged when using --without gtk-doc. -- Patrick
