Laca:
Please see my comments in line
Laszlo (Laca) Peter ??:
> Hi Chris,
>
> On Thu, 2008-02-14 at 13:59 +0800, C Wang wrote:
>
>> Attached spec file are for delivering SUNWgtkmm package to Nv. please
>> help to review
>>
>
>
>> Requires: SFEglibmm
>> Requires: SFEcairomm
>>
>
> Please update these, there should be no SFE dependency.
>
>
I'll change it
>> Requires: SUNWgnome-base-libs
>> Requires: SUNWlibms
>> Requires: SFEsigcpp
>> Requires: SUNWlibC
>> BuildRequires: SFEsigcpp-devel
>> BuildRequires: SFEglibmm-devel
>> BuildRequires: SFEcairomm-devel
>> BuildRequires: SUNWgnome-base-libs-devel
>>
>> %package devel
>> Summary: gtkmm - C++ Wrapper for the Gtk+ Library -
>> developer files
>> SUNW_BaseDir: %{_basedir}
>> %include default-depend.inc
>> Requires: %name
>> Requires: SUNWgnome-base-libs-devel
>> Requires: SFEglibmm-devel
>> Requires: SFEsigcpp-devel
>>
>
> Same comment.
>
>
>> %prep
>> rm -rf %name-%version
>> mkdir %name-%version
>> %gtkmm.prep -d %name-%version
>>
>> %build
>> export CFLAGS="%optflags"
>> export RPM_OPT_FLAGS="$CFLAGS"
>> export LDFLAGS="%_ldflags"
>> %gtkmm.build -d %name-%version
>>
>> %install
>> %gtkmm.install -d %name-%version
>>
>> # Move demo to demo directory
>> #
>> install -d $RPM_BUILD_ROOT%{_prefix}/demo/jds/bin
>> mv $RPM_BUILD_ROOT%{_bindir}/gtkmm-demo $RPM_BUILD_ROOT
>> %{_prefix}/demo/jds/bin
>> rm -r $RPM_BUILD_ROOT%{_bindir}
>>
>> %clean
>> #rm -rf $RPM_BUILD_ROOT
>>
>> %files
>> %defattr (-, root, bin)
>> %dir %attr (0755, root, bin) %{_libdir}
>> %{_libdir}/lib*
>>
>> %files devel
>> %defattr (-, root, bin)
>> %dir %attr (0755, root, bin) %{_libdir}
>> %dir %attr (0755, root, other) %{_libdir}/pkgconfig
>> %{_libdir}/pkgconfig/*
>> %{_libdir}/gtkmm*
>> %{_libdir}/gdkmm*
>> %dir %attr (0755, root, sys) %{_datadir}
>> %{_datadir}/gtkmm-2.4/demo
>> %dir %attr (0755, root, other) %{_datadir}/doc
>> %{_datadir}/doc/*
>> %dir %attr (0755, root, bin) %{_includedir}
>> %{_includedir}/*
>> %dir %attr (0755, root, bin) %{_prefix}/demo
>> %dir %attr (0755, root, bin) %{_prefix}/demo/jds
>> %dir %attr (0755, root, bin) %{_prefix}/demo/jds/bin
>> %{_prefix}/demo/jds/bin/gtkmm-demo
>>
>>
>> %changelog
>> * The Feb 18 2008 - chris.wang at sun.com
>> - Move gtkmm-demo to /usr/demo/jds/bin per requested by ARC
>> * Tue Jan 29 2008 - chris.wang at sun.com
>> - create
>>
>>
>>
>>
>>
>>
>>
>> rpm spec file
>> attachment
>> (gtkmm.spec)
>>
>> #
>> # spec file for package gtkmm
>> #
>> # Copyright (c) 2008 Sun Microsystems, Inc.
>>
>
> Very minor issue, but the (c) shouldn't be there.
>
>
>> # This file and all modifications and additions to the pristine
>> # package are under the same license as the package itself.
>> #
>> # Owner: bewitche
>> #
>>
>> Name: gtkmm
>> License: LGPL
>> Group: System/Libraries
>> Version: 2.12.4
>> Release: 1
>> Distribution: Java Desktop System
>> Vendor: Sun Microsystems, Inc.
>> Summary: gtkmm - C++ Interfaces for GTK+ and GNOME
>> Source:
>> http://download.gnome.org/sources/gtkmm/2.12/gtkmm-%{version}.tar.bz2
>> # date:2008-02-18 owner:bewitche type:bug
>> Patch1: gtkmm-01-getc_unlocked.diff
>> # date:2008-02-18 owner:bewitche type:bug
>> Patch2: gtkmm-02-ignore-defs.diff
>> # date:2008-02-18 owner:bewitche type:bug
>> Patch3: gtkmm-03-demo.diff
>> # date:2008-02-18 owner:bewitche type:bug
>> Patch4: gtkmm-04-demo-installation.diff
>>
>
> Please submit these bug fixes upstream and/or update the
> comments to include the bugids.
>
>
Do we already have category to file bug against this product?
>> URL: http://www.gtkmm.org/
>> BuildRoot: %{_tmppath}/%{name}-%{version}-build
>>
>> %prep
>> %setup -q -n gtkmm-%version
>> %patch1 -p1
>> %patch2 -p1
>> %patch3 -p1
>> %patch4 -p1
>>
>> %build
>> CPUS=`/usr/sbin/psrinfo | grep on-line | wc -l | tr -d ' '`
>> if test "x$CPUS" = "x" -o $CPUS = 0; then
>> CPUS=1
>> fi
>> %if %cc_is_gcc
>> %else
>> export CXX="${CXX} -norunpath"
>> %endif
>> export CXXFLAGS="%cxx_optflags -D_XPG4_2 -D__EXTENSIONS__"
>>
>>
>> cp ./demos/background.jpg ./demos/gtk-demo
>>
>
> Why?
>
>
background.jpg is needed by gtk-demo, we may copy the file to directory
and install together, or we may
modify the Makefile.am to install this single file, I think the way I
choose is much simpler.
>> automake --add-missing
>> autoconf
>> ./configure --prefix=%{_prefix} --mandir=%{_mandir} \
>> --libdir=%{_libdir} \
>> --libexecdir=%{_libexecdir} \
>> --sysconfdir=%{_sysconfdir}
>> make -j$CPUS
>>
>> %install
>> make install DESTDIR=$RPM_BUILD_ROOT
>>
>> rm -f $RPM_BUILD_ROOT%{_libdir}/lib*a
>>
>
>
>> rm -rf $RPM_BUILD_ROOT%{_datadir}/devhelp
>>
>
> Why? We do have devhelp in JDS.
>
>
This is directly copied from the original spec file from SFE, if we need
this, then I can delete this line
> Laca
>
>
>
Chris
