Ok, I'll update the spec accordingly. Thanks for the comments. Regards, Chris
Laszlo (Laca) Peter ??: > On Thu, 2008-02-14 at 17:52 +0800, C Wang wrote: > >> Laca: >> Please see my comments in line >> > > >>> Please submit these bug fixes upstream and/or update the >>> comments to include the bugids. >>> >>> >>> >> Do we already have category to file bug against this product? >> > > >From this url: > > >>>> URL: http://www.gtkmm.org/ >>>> > > I found this: http://www.gtkmm.org/bugs.shtml#NewBugs > Please submit bugs there. > > >>>> BuildRoot: %{_tmppath}/%{name}-%{version}-build >>>> >>>> %prep >>>> %setup -q -n gtkmm-%version >>>> %patch1 -p1 >>>> %patch2 -p1 >>>> %patch3 -p1 >>>> %patch4 -p1 >>>> >>>> %build >>>> CPUS=`/usr/sbin/psrinfo | grep on-line | wc -l | tr -d ' '` >>>> if test "x$CPUS" = "x" -o $CPUS = 0; then >>>> CPUS=1 >>>> fi >>>> %if %cc_is_gcc >>>> %else >>>> export CXX="${CXX} -norunpath" >>>> %endif >>>> export CXXFLAGS="%cxx_optflags -D_XPG4_2 -D__EXTENSIONS__" >>>> >>>> >>>> cp ./demos/background.jpg ./demos/gtk-demo >>>> >>>> >>> Why? >>> >>> >>> >> background.jpg is needed by gtk-demo, we may copy the file to directory >> and install together, or we may >> modify the Makefile.am to install this single file, I think the way I >> choose is much simpler. >> > > It is, it's just not clear why it's happening. I suggest you add > a comment in the spec file that explains why you're doing this. > > >>>> rm -rf $RPM_BUILD_ROOT%{_datadir}/devhelp >>>> >>>> >>> Why? We do have devhelp in JDS. >>> >>> >>> >> This is directly copied from the original spec file from SFE, >> > > that doesn't mean it's right (; > > >> if we need this, then I can delete this line >> > > I think when the original SFE spec file was written we didn't have > devhelp in JDS. We have now, so it should be fine to leave this > in the devel package. > > Thanks, > Laca > > >
