Hi,
Thanks much for your reviews.
> I noticed that you add make commands to the %prep section.
> This is a bit unusual. What does it do?
The make uses spec-files/po-sun/Makefile.template
Please find the following part.
--- spec-files/po-sun-orig/Makefile.template 1970-01-01 09:00:00.000000000
+0900
+++ spec-files/po-sun/Makefile.template 2006-12-27 17:48:19.014372000 +0900
@@ -0,0 +1,14 @@
+
+all:
+ @for po_sun in $(POFILES); do \
+ po=$(PODIR)/$$po_sun; \
+ if test -f $$po; then \
+ echo "Merging $$po_sun ..."; \
+ msgcat --use-first $$po_sun $$po -o $$po; \
+ fi; \
+ done
+
+top_builddir = ..
+PODIR = $(top_builddir)/po
+POFILES = $(wildcard *.po)
+
I thought msgcat as the patch of .po likes the patch of source codes.
Why I use make is the change is one line in .spec file.
Do you mean "make on %prep" may be unusual?
If so, how about the following options?
- Change "make" to "make prep-after".
- Change the make command to a script on prep. e.g. "bash -x foo.sh"
> Oops! That should be a "*/" at the end, right?
I'm very sorry for the mistake. I noticed it after sent this mail and /net
files is already fixed.
> Why did you change the English string from "All Applications" to
> "Applications"?
Sorry, I thought "All Applications" is typo because the internal
ui-spec/launch.htm shows both "Applications" and "All Applications" and JDS 3.1
is "Applications".
e.g. "Main->Applications->Accessories"
I cannot grep "All Application" translations from JDS 3.1 messages files so it
will be a new string.
I'll change "Applications" to "All Applications".
Finally I'll send the reviced patch again.
Thanks,
fujiwara
Laszlo (Laca) Peter wrote:
> Fujiwara-san,
>
> Generally looks okay, some comments, issues, questions below:
>
> On Wed, 2007-01-10 at 21:18 +0900, Takao Fujiwara - Tokyo S/W Center
> wrote:
>
>>+%if %build_l10n
>>+bzcat %SOURCE8 | tar xf -
>>+cd po-sun; make; cd ..
>>+%endif
>
>
> I noticed that you add make commands to the %prep section.
> This is a bit unusual. What does it do?
>
>
>> +++ gnome-panel-2.16.1-hacked/gnome-panel/menu.c 2006-11-16
>>01:39:21.692923000 +1300
>>-@@ -1799,13 +1799,93 @@
>>+@@ -1799,13 +1799,94 @@
>> setup_menuitem (item, icon_size, NULL, title,
>>create_invisible_mnemonic);
>> }
>>
>>@@ -36,6 +36,7 @@
>> +
>> + item = gtk_image_menu_item_new ();
>> +
>>++ /* SUN_BRANDING *
>
>
> Oops! That should be a "*/" at the end, right?
>
>
>> - children = gtk_container_get_children (GTK_CONTAINER
>>(main_menu));
>>-+ item = add_xdg_menu (_("All Applications"),
>>"applications.menu", "gnome-applications");
>>++ /* SUN_BRANDING */
>>++ item = add_xdg_menu (_("Applications"), "applications.menu",
>>"gnome-applications");
>
>
> Why did you change the English string from "All Applications" to
> "Applications"?
>
> Thanks,
> Laca
>
>
>
