Hi Chris,
On Wed, 2007-02-14 at 14:35 +0800, C Wang wrote:
> In this part of code in cpu.display
> def show_cpu_info(show):
>
> Dsp.lbl_cpu_info.visible = show
> Dsp.gauge_load.visible = Dsp.plot_load.visible = not show
> if (show):
> Dsp.lbl_cpu_info.value = "Bogomips: %.2f\n%s (%dkB cache)"
> % \
> (sys.cpu_bogomips, sys.cpu_model,
> sys.cpu_cache)
>
> this script is use to display information in the widget, as you can
> see,
> it displays Bogomips info in the widget which is not available in
> Solaris, so I remove the display of bogomips. and I do
> think this is should be a internal patch.
Would it not be possible to do something like this:
if (show):
if (sys.cpu_bogomips > 0):
Dsp.lbl_cpu_info.value = ....
else:
Dsp.lbl_cpu_info.value = ....
> The other two fix, one typo and the fix of WeeklyCalendar, I have
> talked to the module owner to put upstream.
Awesome.
> Wish this could be helpful.
Yeah, it makes more sense now. My problem with calling
things like this "branding" that our goal should be to
make these things work out of the box on Solaris.
I.e. if someone decides to download the sources, build
and install manually, then it should just work and
do the right thing.
Thanks,
Laca
