Ghee: Some comments:
> diff -urN gtk+-2.10.6/gtk/Makefile.am > ../SUNWgnome-base-libs-2.17.1.hacked/gtk+-2.10.6/gtk/Makefile.am > --- gtk+-2.10.6/gtk/Makefile.am 2006-10-02 17:27:53.000000000 +0000 > +++ ../SUNWgnome-base-libs-2.17.1.hacked/gtk+-2.10.6/gtk/Makefile.am > 2006-12-05 18:38:16.249053000 +0000 > @@ -12,8 +12,12 @@ > if HAVE_CUPS > GTK_PRINT_BACKENDS=file,cups > else > +if HAVE_PAPI > +GTK_PRINT_BACKENDS=file,lpr,papi > +else > GTK_PRINT_BACKENDS=file,lpr > endif > +endif The above seems a bit gross to me. What about when other people want to add other backends. Wouldn't it be better to do something like this: if HAVE_PAPI EXTRA_BACKEND=",papi" endif GTK_PRINT_BACKENDS=file,lpr,$(EXTRA_BACKENDS) so that if more people want to add more backends then you can just add more if/endif blocks and append to EXTRA_BACKEND? > +DIST_SUBDIRS=cups file lpr papi > diff -urN gtk+-2.10.6/modules/printbackends/lpr/gtkprintbackendlpr.c > ../SUNWgnome-base-libs-2.17.1.hacked/gtk+-2.10.6/modules/printbackends/lpr/gtkprintbackendlpr.c > --- gtk+-2.10.6/modules/printbackends/lpr/gtkprintbackendlpr.c > 2006-06-21 18:16:58.000000000 +0000 > +++ > ../SUNWgnome-base-libs-2.17.1.hacked/gtk+-2.10.6/modules/printbackends/lpr/gtkprintbackendlpr.c > 2006-12-05 18:38:16.293646000 +0000 > @@ -400,7 +400,6 @@ > gtk_printer_set_has_details (printer, TRUE); > gtk_printer_set_icon_name (printer, "gtk-print"); > gtk_printer_set_is_active (printer, TRUE); > - gtk_printer_set_is_default (printer, TRUE); > > gtk_print_backend_add_printer (GTK_PRINT_BACKEND (backend), printer); > g_object_unref (printer); Might it be nicer to define a configure --enable or --with argument to specify what the default should be rather than hacking the code directly like this? Brian
