2 quick comments before looking at the patch in any detail:

On Thu, 2006-11-16 at 15:55 +0000, Ghee Teo wrote:
> #owner: gheet  bugster: 6493997

No spaces before the user id and the bugid please.  You will also need
the type of the
bug and the creation date.

> diff -urN gtk+-2.10.6/modules/printbackends/papi/Makefile.in 
> ../SUNWgnome-base-libs-2.16.1.hacked/gtk+-2.10.6/modules/printbackends/papi/Makefile.in
> --- gtk+-2.10.6/modules/printbackends/papi/Makefile.in  1970-01-01 
> 00:00:00.000000000 +0000
> +++ 
> ../SUNWgnome-base-libs-2.16.1.hacked/gtk+-2.10.6/modules/printbackends/papi/Makefile.in
>      2006-10-17 17:36:45.659516000 +0000
> @@ -0,0 +1,649 @@
> +# Makefile.in generated by automake 1.9.6 from Makefile.am.

Note where it says "generated by automake".
Please don't include generated files in patches.  Patch Makefile.am and
make
sure the spec file calls automake to rebuild Makefile.in.

Laca



Reply via email to