I added 2 patches. One is to fix bugster bug 6767189, the other one is to fix the manpage issue. So the corresponding SUNWgnome-media-center.spec and elisa.spec also were modified. Please review. For detailed info, please see diff attached.
Thanks, Jerry Jerry Yu wrote: > Modified based on Brian and Halton's inputs. For the detailed > modification info, please check the file named diff attached. > > Thanks, > - Jerry > > Brian Cameron wrote: >> Jerry: >> >> In the SUNWgnome-media-center.spec file *and* the elisa.spec file >> both say the following in %description: >> >> Elisa is a project to create an open source cross platform media >> center solution. >> >> Instead just say "Elisa is an open-source cross-platform media center >> solution." >> >> Note that we don't support UPnP or DAAP plugins in our initial release >> of Elisa, so it probably doesn't fully support the "DLNA standard" on >> Solaris until we add such plugins in a future release. I'd remove the >> "Elisa will also interoperate with device following the DLNA standard. >> >> You say: >> >> interoperate with devices following the DLNA standard. >> systems. >> >> The word "systems" seems to be floating by itself. I'm guessing this >> word should be removed also. >> >> ------ >> >> In the elisa-plugins-bad.spec file the description says: >> >> The Elisa bad plugins set contains plugins known to be working well >> but with code needing more QA (unittests, code reviews). >> >> We might want to highlight that these plugins are needed for Elisa to >> work, even though they may have some QA issues. And thus explain why >> we are shipping them. >> > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: elisa-02-docs.diff URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20081126/df409f37/attachment.ksh> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: elisa-03-manpage.diff URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20081126/df409f37/attachment-0001.ksh> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: SUNWgnome-media-center.spec URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20081126/df409f37/attachment-0002.ksh> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: elisa.spec URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20081126/df409f37/attachment-0003.ksh> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: diff URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20081126/df409f37/attachment-0004.ksh>
