Hi Brian, Please see my comments inline. On Tue, 2008-08-05 at 00:50 -0500, Brian Cameron wrote: > > 2) In /usr/share/gdm/default.conf, tell gdmgreeter the background is a > > image and the image is /usr/share/pixmaps/splash/indiana-splash.jpg. > > If we change default.conf, we should change it in the two gdm-01 > patches, not in separate patches. The idea of the gdm-01 patch is > that is where all changes to default.conf goes. My modification is for gdm-01-indiana.diff, not a separate patch. > > > 3) In gui/greeter/greeter.c, add the code to scale the image and show it > > as the background. > > Why not modify the code so that if BackgroundType=1 that it calls > setup_background and otherwise it calls > gdm_common_setup_background_color if GDM_KEY_GRAPHICAL_THEMED_COLOR > is not empty? > > This change could go upstream, I think.
I am updating the patch to make it work in the same way which login dialog of gdmgreeter and splash dialog of gnome-session use. The original patch scales the picture to cover the background which is different from the others. Regards, Jedy > > Brian
