Hi Brian, Please see my comments inline. On Tue, 2008-08-05 at 18:43 -0500, Brian Cameron wrote: > Jedy: > > >> If we change default.conf, we should change it in the two gdm-01 > >> patches, not in separate patches. The idea of the gdm-01 patch is > >> that is where all changes to default.conf goes. > > My modification is for gdm-01-indiana.diff, not a separate patch. > > The change should also be made to the gdm-01-sun-branding.diff, or > the fix will only go into OpenSolaris, and not Nevada.
Nevada is a little different with OpenSolaris. Nevada shows a small image in the center of the screen and fill the other space with blue. OpenSolaris ships a big enough image which is 1920x1200. In most cases its central part should be clipped and shown as the background. And I will ask Frank what should be done if the screen is bigger than the image. > >>> 3) In gui/greeter/greeter.c, add the code to scale the image and show it > >>> as the background. > >> Why not modify the code so that if BackgroundType=1 that it calls > >> setup_background and otherwise it calls > >> gdm_common_setup_background_color if GDM_KEY_GRAPHICAL_THEMED_COLOR > >> is not empty? > >> > >> This change could go upstream, I think. > > > > I am updating the patch to make it work in the same way which login > > dialog of gdmgreeter and splash dialog of gnome-session use. The > > original patch scales the picture to cover the background which is > > different from the others. > > If you could also make the patch more backwards compatible, then it > could go upstream. > > To do this just modify the setup_background function so it calls > setup_background_color when the bg_type is not IMAGE or IMAGE_AND_COLOR > and when either GDM_KEY_GRAPHICAL_THEMED_COLOR or > GDM_KEY_BACKGROUND_COLOR is set, similar to the old logic. > > In other words, this could be done in the function setup_background > if image == NULL at the end of the current function. Will do. Regards, Jedy > > Brian >
