Kevin,

Looks good.  Just a few things:

# Owner: Kevin McAreavey
- Please use your opensolaris.org Id here.

SUNW_Copyright: %{name}.copyright
- Please include the copyright file in the review.

%dir %attr(-,root,sys) /usr
- you don't need to define /usr in %files as this
   is the BaseDir of your package.  If it isn't - it
   probably should be, eg:
        SUNW_BaseDir:            %{_basedir}
   You only need to define dirs below your BaseDir



Dermot

Reply via email to