Willie: Normally we send the review comments at the same time that we also commit the changes to spec-files. You don't need to wait for review approval or anything. If someone raises an issue with a patch, it's generally accepted the the person who did the work will fix any reasonable improvement suggestions.
I don't see this patch in spec-files yet, so it should be committed. The patch looks good to me, btw. Brian > 1) A new patch file for the SADA support in eSpeak. This adds support > for big endian architectures using the same endian coding style used in > the rest of eSpeak. Patch has been submitted upstream as well. > > 2) A patch to SUNWespeak.spec to define the macro eSpeak expects when > being compiled on a big endian architecture. The patch also builds/runs > (but doesn't install, since it's not needed) the utility to convert the > needed data files to big endian format. > > I tested this both on x86 and SPARC and it works great. > > Will
