Will,
Is this the fix for bugster bug 6741969?
If so, we usually need to add the bugster bug ID and bugzilla bug ID
(if it has) in the patch comments line.
Here is an example:
# date:2006-12-26 bugzilla:389668 bugster:6504980 owner:jyu_mit type:bug
Patch5: evolution-05-memo.diff
After checking in the patch, we also will mark the bug as fix available
in bugster so that QA will verify it.
If this is the fix, please let me know the upstream bug ID. I can help
you to update the patch comments and bug status.
Thanks,
Harry
On Fri, 2008-08-29 at 14:37 -0400, Willie Walker wrote:
> Thanks much, Brian! Committed:
>
> bash-3.2$ svn commit
> Sending SUNWespeak.spec
> Adding patches/espeak-02-endian.diff
> Transmitting file data ..
> Committed revision 15151.
>
> Will
>
> Brian Cameron wrote:
> > Willie:
> >
> > Normally we send the review comments at the same time that we also
> > commit the changes to spec-files. You don't need to wait for review
> > approval or anything. If someone raises an issue with a patch, it's
> > generally accepted the the person who did the work will fix any
> > reasonable improvement suggestions.
> >
> > I don't see this patch in spec-files yet, so it should be committed.
> > The patch looks good to me, btw.
> >
> > Brian
> >
> >
> >> 1) A new patch file for the SADA support in eSpeak. This adds support
> >> for big endian architectures using the same endian coding style used
> >> in the rest of eSpeak. Patch has been submitted upstream as well.
> >>
> >> 2) A patch to SUNWespeak.spec to define the macro eSpeak expects when
> >> being compiled on a big endian architecture. The patch also
> >> builds/runs (but doesn't install, since it's not needed) the utility
> >> to convert the needed data files to big endian format.
> >>
> >> I tested this both on x86 and SPARC and it works great.
> >>
> >> Will
> >
>
--
Harry.Lu at Sun.COM
Solaris Desktop Group, Sun Microsystems
Tel: +86-10-82618200 ext. 82870/ +86-10-62673870
Fax: +86-10-62780969
