Hi Dermot, Thanks a lot for your reply. Please, check the updated SUNWmyspell-dictionary.spec(attched).
Dermot McCluskey wrote: > Yuriy, > > - you should indent the scriptlets in your specfile. They > are difficult to read otherwise SUNWmyspell-dictionary.spec is updated with proper indentation. > > - you should have a %changelog section > (with 1 entry - "initial version") SUNWmyspell-dictionary.spec is updated with %changelog section. > > - is there really no version number attached to most of the > source filenames? Are these files likely to be Sorces of dictionaries were taken from community and their locations are correct in Source section of SUNWmyspell-dictionary.spec on the moment of creation of SUNWmyspell-dictionary-* pkgs. > > -line 175: > install -d $RPM_BUILD_ROOT%_myspelldir > (& lines 191, 197, 204) - should these be outside the "for" loop? Corrected according to your advice, thanks. Kind regards, yuriy > > > Regards, > Dermot > > > Yuriy Kuznetsov wrote On 05/01/07 16:21,: > >> Hi All, >> >> G11n team is requesting review of SUNWmyspell-dictionary.spec(see >> attached) which would build the following packages : >> >> SUNWmyspell-dictionary-cs >> SUNWmyspell-dictionary-de >> SUNWmyspell-dictionary-en >> SUNWmyspell-dictionary-es >> SUNWmyspell-dictionary-fr >> SUNWmyspell-dictionary-hu >> SUNWmyspell-dictionary-it >> SUNWmyspell-dictionary-pl >> SUNWmyspell-dictionary-ptBR >> SUNWmyspell-dictionary-ru >> SUNWmyspell-dictionary-sv >> SUNWmyspell-dictionary-extra * >> >> * SUNWmyspell-dictionary-extra package will include foloowing >> dictionaries : ca_ES, da_DK, el_GR, he_IL, nb_NO, >> nl_NL, sk_SK, sl_SI. >> >> >> - These packages provide spell dictionaries for common dictionaries >> between GNOME, Evolution, Firefox, Thunderbird and StarOffice. >> - ARC fast track was sent by Irene Huang(Irene.Huang at Sun.COM), >> Harry Lu(Harry.Fu at Sun.COM) and now under the review(see attached). >> - SUNWmyspell-dictionary.spec is planned to integrate in >> vermillion_65/snv_65. >> - Currently Firefox and Thunderbird have the dictionaries in the >> packages and we move those dictionaries to this package. >> - We provides dict symlinks in this package for Thunderbird, >> Firefox because FF/TB needs the filename format of "xx-XX" but >> enchant needs the filename format "xx_XX" and All dict related >> symlinks are in this packages. >> - SUNW_PkgList has SUNWgnome-spell and SUNWthunderbird but not >> StarOffice at the moment. >> >> >> Thanks in advance, >> yuriy >> -------------- next part -------------- A non-text attachment was scrubbed... Name: SUNWmyspell-dictionary.spec.tar Type: application/x-tar Size: 17408 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20070501/c47bf33a/attachment.tar>
