I would like to recommend that we make the following change to the SUNWgnome-dtlogin-integration package.
This moves the dbus-launch call from /usr/dt/config/Xinitrc.jds to /usr/dt/config/Xsession.jds script. This change makes it possible to remove the dbus-01-dbus-launch.diff patch that we currently apply to work around the problem described below (in the patch I add this comment to the /usr/dt/config/Xsession.jds script to explain what we are doing): # It is best to call dbus-launch from here, before /usr/dt/bin/Xsession # gets called. This is because the /usr/dt/bin/Xsession script uses # /usr/dt/bin/sdt_shell to launch Xsession2.jds (then Xinitrc.jds and # finally the actual session). The sdt_shell program causes problems # for dbus-launch because it creates a controlling terminal which causes # any sub-shell to receive an end of file character (Control-D). This # end of file on stdin makes dbus-launch not work properly, so running # from here makes it work better. Making this change, and removing the dbus-01-dbus-launch.diff patch is good because this patch is really a hack and disables some checking that dbus-launch uses to know when it should exit properly. While the patch seems to work okay, it is better if we move towards using the unpatched community code. Can this go upstream? I haven't yet applied it since I wanted it to get approval first. I have tested this change and also removing the dbus-01-dbus-launch.diff patch and things work well with this change. Brian -------------- next part -------------- A non-text attachment was scrubbed... Name: dtlogin.diff Type: text/x-patch Size: 3558 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20070511/059607d9/attachment.bin>
