Hi Brian, It seems Xsession.jds also be sourced by GDM when start up CDE from GDM, is it right? If so, there will be some differences by the default settings for launching CDE. I mean, if users start CDE from dtlogin, there are no SSH-agent and Dbus-agent, while there are if start CDE from gdm. I think it should be a problem, right? So from my perspective, I would like to reject this fix, but I'm NOT sure if I'm right.
Thanks, lin Brian Cameron wrote: > > I would like to recommend that we make the following change to the > SUNWgnome-dtlogin-integration package. > > This moves the dbus-launch call from /usr/dt/config/Xinitrc.jds to > /usr/dt/config/Xsession.jds script. This change makes it possible > to remove the dbus-01-dbus-launch.diff patch that we currently apply > to work around the problem described below (in the patch I add this > comment to the /usr/dt/config/Xsession.jds script to explain what we > are doing): > > # It is best to call dbus-launch from here, before /usr/dt/bin/Xsession > # gets called. This is because the /usr/dt/bin/Xsession script uses > # /usr/dt/bin/sdt_shell to launch Xsession2.jds (then Xinitrc.jds and > # finally the actual session). The sdt_shell program causes problems > # for dbus-launch because it creates a controlling terminal which causes > # any sub-shell to receive an end of file character (Control-D). This > # end of file on stdin makes dbus-launch not work properly, so running > # from here makes it work better. > > Making this change, and removing the dbus-01-dbus-launch.diff patch > is good because this patch is really a hack and disables some checking > that dbus-launch uses to know when it should exit properly. While the > patch seems to work okay, it is better if we move towards using the > unpatched community code. > > Can this go upstream? I haven't yet applied it since I wanted it to > get approval first. I have tested this change and also removing the > dbus-01-dbus-launch.diff patch and things work well with this change. > > Brian > > > > -- x82120 / +86 10 82618200
